Skip to content

Handle IBC deposits/withdraws to/from payment addresses #4939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 64 commits into
base: main
Choose a base branch
from
Open

Handle IBC deposits/withdraws to/from payment addresses #4939

wants to merge 64 commits into from
+2,970 −1,146

Conversation

@sug0
Copy link
Collaborator

@sug0 sug0 commented Oct 22, 2025 •
edited
Loading

Describe your changes

Closes #4830
Closes #4168

Allow IBC deposits into payment addresses (without generating MASP transactions), and IBC withdraws from payment addresses (to automatically get refunded, if an IBC unshielding transfer fails on the counter-party).

These changes should substantially improve the UX of MASP over IBC.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo

@sug0 sug0 added IBC UX MASP breaking-change breaking:consensus Consensus breaking change that requires a hard-fork do-not-merge Do not merge for now labels Oct 22, 2025
@sug0 sug0 requested review from grarco, murisi and yito88 October 22, 2025 17:55
@mergify
Copy link
Contributor

mergify bot commented Oct 22, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 0f1c098.

🟢 All jobs passed!

But CI Insights is watching 👀

@brentstone brentstone added this to the Next Release milestone Oct 24, 2025
sug0 added 19 commits October 27, 2025 13:15
@sug0
Implement IBC account ids
6c81768
@sug0
Insert MASP as verifier from IBC payment addr signer
f8be657
@sug0
Rename is_shielded field to has_masp_tx
ae2948a
@sug0
Add shielded token store
c8ef30e
@sug0
Integrate shielded token store with IBC VP
4ba43bd
@sug0
Encode MASP payment addrs with bech32 legacy codec
d3d7d4e
@sug0
Create note from MASP payment addr
4f55905
@sug0
IBC account id helper predicates
fe8b410
@sug0
Make IBC amount conversions infallible
ca6d710
@sug0
Mint MASP notes via IBC
7d417a1
@sug0
Remove storage impls from ibc protocol ctx
2f72d1c
@sug0
Simplify params bounds in ibc transfer def
cf07ab2
@sug0
Integrate transparent token store with IBC VP
ce601ae
@sug0
Read token denom from storage when minting MASP note
5e10bab
@sug0
Keep track of nr of MASP IBC shieldings
ff21d61
@sug0
Seed MASP note with IBC shielding counter
918b545
@sug0
Integrate params store with IBC transfer ctx
a0ee269
@sug0
Add convenience method to compute MASP epoch
c75f5f6
@sug0
Expose storage predicate to check if a conversion exists
b3d6814
tzemanovic
tzemanovic reviewed Oct 31, 2025
View reviewed changes
tzemanovic
tzemanovic reviewed Oct 31, 2025
View reviewed changes
tzemanovic
tzemanovic reviewed Oct 31, 2025
View reviewed changes
tzemanovic
tzemanovic reviewed Oct 31, 2025
View reviewed changes
tzemanovic
tzemanovic reviewed Oct 31, 2025
View reviewed changes
sug0 added a commit that referenced this pull request Nov 3, 2025
@sug0
Changelog for #4939
0989749
@sug0 sug0 force-pushed the tiago/znam-ibc-shielding branch from 07ab1eb to 0989749 Compare November 3, 2025 10:56
@sug0 sug0 requested a review from tzemanovic November 3, 2025 10:57
@github-actions github-actions bot added the breaking:api public API breaking change label Nov 3, 2025
sug0 added a commit that referenced this pull request Nov 3, 2025
@sug0
Changelog for #4939
15014c8
@sug0 sug0 force-pushed the tiago/znam-ibc-shielding branch from 0989749 to 15014c8 Compare November 3, 2025 14:58
sug0 added a commit that referenced this pull request Nov 3, 2025
@sug0
Changelog for #4939
01a2ea0
@sug0 sug0 force-pushed the tiago/znam-ibc-shielding branch from 15014c8 to 01a2ea0 Compare November 3, 2025 15:23
@sug0 sug0 mentioned this pull request Nov 4, 2025
Open
3 tasks
yito88
yito88 approved these changes Nov 4, 2025
View reviewed changes
Copy link
Collaborator

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thank you!

sug0 added a commit that referenced this pull request Nov 4, 2025
@sug0
Changelog for #4939
ea7ac31
@sug0 sug0 force-pushed the tiago/znam-ibc-shielding branch from 01a2ea0 to ea7ac31 Compare November 4, 2025 11:20
@sug0
Copy link
Collaborator Author

sug0 commented Nov 4, 2025

sorry about the f-push, had to fix shielded swaps

@sug0 sug0 force-pushed the tiago/znam-ibc-shielding branch from ea7ac31 to 0f1c098 Compare November 4, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

@yito88 yito88 yito88 approved these changes

@murisi murisi Awaiting requested review from murisi

@grarco grarco Awaiting requested review from grarco

Assignees

No one assigned

Labels

breaking:api public API breaking change breaking:consensus Consensus breaking change that requires a hard-fork breaking-change IBC MASP UX

Projects

None yet

Milestone

Next Release

Development

Successfully merging this pull request may close these issues.

Blind IBC to znam MASP depositing (memoless) Shielded refund design

5 participants

@sug0 @tzemanovic @yito88 @brentstone